Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Using iso timedelta in settings #6656

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 4, 2024

What do these changes do?

In preparation of moving to pydantic2, timedelta fields now have to be formatted with the iso format.

minor: typo rename of some settings which has no impact

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (cd20a2c) to head (5f15eae).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cd20a2c) and HEAD (5f15eae). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (cd20a2c) HEAD (5f15eae)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6656       +/-   ##
===========================================
- Coverage   87.68%   65.53%   -22.15%     
===========================================
  Files        1527      632      -895     
  Lines       60817    31803    -29014     
  Branches     2104      265     -1839     
===========================================
- Hits        53326    20842    -32484     
- Misses       7166    10900     +3734     
+ Partials      325       61      -264     
Flag Coverage Δ
integrationtests 64.86% <ø> (+0.01%) ⬆️
unittests 97.17% <100.00%> (+11.59%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent 97.17% <100.00%> (ø)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.42% <ø> (-14.49%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.79% <ø> (-30.01%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.82% <ø> (-29.49%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd20a2c...5f15eae. Read the comment docs.

@GitHK GitHK self-assigned this Nov 4, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 4, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 4, 2024
@GitHK GitHK marked this pull request as ready for review November 4, 2024 13:04
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i guess, i believe you

.env-devel Show resolved Hide resolved
@GitHK GitHK enabled auto-merge (squash) November 5, 2024 09:30
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 5, 2024 13:17
Copy link

sonarqubecloud bot commented Nov 5, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit 43f678f into ITISFoundation:master Nov 5, 2024
83 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants