🐛 do not send bps metrics where they are less than 1

[GitHK]

What do these changes do?

Transfer rates that are almost 0 are making the results inaccurate. Sending transfer rates only when they are >= 1 bps.

Related issue/s

• fixes Director-v2 writes a pull rate when downloading nothing #6621
• fixes simcore_service_director_v2 observer raises exception due to invalid stop_duration during event #6675

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.11%. Comparing base (db3aacf) to head (b752f9b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (db3aacf) and HEAD (b752f9b). Click for more details.

HEAD has 28 uploads less than BASE

Flag	BASE (db3aacf)	HEAD (b752f9b)
unittests	29	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #6634       +/-   ##
===========================================
- Coverage   87.54%   67.11%   -20.43%     
===========================================
  Files        1479      609      -870     
  Lines       59316    30875    -28441     
  Branches     2106      265     -1841     
===========================================
- Hits        51928    20723    -31205     
- Misses       7063    10091     +3028     
+ Partials      325       61      -264     

Flag	Coverage Δ		*Carryforward flag
integrationtests	63.74% <100.00%> (-1.09%)	⬇️	Carriedforward from be8fac6
unittests	84.22% <33.33%> (-1.17%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.44% <ø> (-7.84%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	90.79% <100.00%> (-0.13%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	59.79% <ø> (-30.01%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	79.42% <ø> (-5.73%)	⬇️
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	57.96% <ø> (-31.32%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db3aacf...b752f9b. Read the comment docs.

[pcrespov]

👍

[sanderegg]

Thanks, but can you change the implementation to really check whether any file was transferred instead of the hack with the rate. what if the rate really goes down?? then we will miss it.

[sanderegg]

Great, thanks for the changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud