Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨🐛 [Frontend] Retry /auth/logout call if times out #6558

Merged
merged 21 commits into from
Oct 21, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 18, 2024

What do these changes do?

This PR implements the retry functionality for the generic fetch requests.

For now, only the logout will retry max 5 times, with a 5" timeout.

Demo with timeout set to 5ms:
retryLogout

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 18, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 18, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 18, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 18, 2024 12:58
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@odeimaiz odeimaiz enabled auto-merge (squash) October 18, 2024 15:05
Copy link

@odeimaiz odeimaiz merged commit 118b363 into ITISFoundation:master Oct 21, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants