Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Search with tags filter #6554

Merged
merged 13 commits into from
Oct 21, 2024
Merged

🎨 [Frontend] Search with tags filter #6554

merged 13 commits into from
Oct 21, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 17, 2024 •
edited
Loading

What do these changes do?

The search functionality also accepts tag_ids in the query and they are only used if the user types (searches) some text.

In other words, tags behave like current-context filters, being the current context the search results view or the workspace/folders view.

Bonus:

  • Folders: pass order_by query argument

SearchByTaga

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 17, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 17, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 17, 2024
@odeimaiz odeimaiz changed the title 🎨 [Fronent] Search with tags 🎨 [Frontend] Search with tags Oct 17, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Search with tags 🎨 [Frontend] Search with tags filter Oct 21, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 21, 2024 09:15
@odeimaiz odeimaiz enabled auto-merge (squash) October 21, 2024 09:22
pcrespov
pcrespov reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz disabled auto-merge October 21, 2024 09:32
sanderegg
sanderegg reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz enabled auto-merge (squash) October 21, 2024 12:47
@odeimaiz odeimaiz merged commit 6e14235 into ITISFoundation:master Oct 21, 2024
51 checks passed
@odeimaiz odeimaiz deleted the enh/search-by-tags branch October 21, 2024 13:11
This was referenced Oct 22, 2024
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@calys calys Awaiting requested review from calys

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.

glitches with folders
5 participants
@odeimaiz @ignapas @pcrespov @sanderegg @matusdrobuliak66