Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Expose env var to raise timeout of downloading/uploading data to and from S3 #6494

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 7, 2024

What do these changes do?

Exposes setting which allows to configure the timeout for uploading/downloading data to S3.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 7, 2024
@GitHK GitHK added High Priority a totally crucial bug/feature to be fixed asap t:enhancement Improvement or request on an existing feature a:director-v2 issue related with the director-v2 service labels Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (8e5c597).
Report is 622 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6494      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1540    +1530     
  Lines         214   63138   +62924     
  Branches       25    2058    +2033     
=========================================
+ Hits          181   55639   +55458     
- Misses         23    7182    +7159     
- Partials       10     317     +307     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.0% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1490 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review October 7, 2024 06:53
@GitHK GitHK requested a review from giancarloromeo October 7, 2024 06:53
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also coresponding OPS env var change PR

@GitHK
Copy link
Contributor Author

GitHK commented Oct 7, 2024

Please add also coresponding OPS env var change PR

@matus it's already linked in the devops section, we are trying to merge it

@GitHK GitHK requested a review from matusdrobuliak66 October 7, 2024 07:38
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitHK GitHK removed the High Priority a totally crucial bug/feature to be fixed asap label Oct 8, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 8, 2024
@GitHK GitHK enabled auto-merge (squash) October 8, 2024 15:19
Copy link

sonarqubecloud bot commented Oct 8, 2024

@GitHK GitHK merged commit 2ec4fcb into ITISFoundation:master Oct 8, 2024
56 checks passed
@GitHK GitHK deleted the pr-osparc-hotix-env-var-settings branch October 8, 2024 15:54
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants