Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 improve project full search #6483

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 2, 2024

What do these changes do?

  • ♻️ Reuse the same functions as in project listing to get the same model output (🐛 fixes missing output fields such as access rights, workbench)
  • 🎨 Add order_by and tag_ids query parameters as discussed with @odeimaiz
    • For now I am just back compatible with current tags (I have not yet considered tags access rights which I would like to discuss @pcrespov with you whether it is really necessary)
  • 🗃️ Make project owner mandatory (this is already the case in the production, only the DB constrain was missing)

Related issue/s

How to test

test__list_projects_full_search_with_query_parameters

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.8%. Comparing base (cafbf96) to head (7a161f4).
Report is 618 commits behind head on master.

Files with missing lines Patch % Lines
...ervice_webserver/projects/_crud_handlers_models.py 87.5% 2 Missing ⚠️
...erver/src/simcore_service_webserver/projects/db.py 90.9% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6483      +/-   ##
=========================================
+ Coverage    84.5%   87.8%    +3.2%     
=========================================
  Files          10    1204    +1194     
  Lines         214   52509   +52295     
  Branches       25     950     +925     
=========================================
+ Hits          181   46103   +45922     
- Misses         23    6228    +6205     
- Partials       10     178     +168     
Flag Coverage Δ
integrationtests 64.7% <31.5%> (?)
unittests 85.3% <92.1%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rary/src/servicelib/aiohttp/requests_validation.py 87.5% <ø> (ø)
...mcore_service_webserver/projects/_crud_api_read.py 98.0% <100.0%> (ø)
...mcore_service_webserver/projects/_crud_handlers.py 92.4% <100.0%> (ø)
...rc/simcore_service_webserver/projects/_db_utils.py 92.3% <100.0%> (ø)
...c/simcore_service_webserver/projects/exceptions.py 94.9% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 97.5% <90.9%> (ø)
...ervice_webserver/projects/_crud_handlers_models.py 94.7% <87.5%> (ø)

... and 1207 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: improve project full search 🎨 improve project full search Oct 2, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 2, 2024 15:43
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Oct 2, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Oct 2, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 4, 2024 07:25
Copy link

sonarqubecloud bot commented Oct 4, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit d38a6c3 into ITISFoundation:master Oct 4, 2024
56 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants