Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frees up space on runner for [build] docker images part of the CI #6475

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 1, 2024

What do these changes do?

We are constantly running out of disk space when building the docker images.
To avoid manually clearing the GitHub caches this is a solution that will work.

Removing some unused space for the [build] docker images stage will help finishing the builds.

NOTE the space gained is based on the assigned runner that's why sometimes the CI goes though. In my two attempts I managed to get 14G extra free space. For more details see explanation here:

Gains

Available storage before:
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        73G   53G   21G  72% /
tmpfs           7.9G  172K  7.9G   1% /dev/shm
tmpfs           3.2G  1.1M  3.2G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        74G  4.1G   66G   6% /mnt
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
Available storage after:
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        73G   38G   35G  53% /
tmpfs           7.9G  172K  7.9G   1% /dev/shm
tmpfs           3.2G  1.1M  3.2G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        74G  4.1G   66G   6% /mnt
tmpfs           1.6G   12K  1.6G   1% /run/user/1001

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 1, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Oct 1, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (cafbf96) to head (e829d1f).
Report is 602 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6475      +/-   ##
=========================================
+ Coverage    84.5%   97.8%   +13.2%     
=========================================
  Files          10      13       +3     
  Lines         214     324     +110     
  Branches       25       0      -25     
=========================================
+ Hits          181     317     +136     
+ Misses         23       7      -16     
+ Partials       10       0      -10     
Flag Coverage Δ
unittests 97.8% <ø> (+13.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review October 1, 2024 08:03
Copy link

sonarqubecloud bot commented Oct 1, 2024

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try but it looks to me a bit Q+D solution
BTW, how did you test the space drop in the build container. Note that I was cleaning the cache...

.github/workflows/ci-testing-deploy.yml Show resolved Hide resolved
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @pcrespov. This looks more like a hack than a solution. Also according to the author itself (easimon/maximize-build-space#48).

If you think it is fine, go ahead

@GitHK GitHK merged commit de57e0d into ITISFoundation:master Oct 1, 2024
51 checks passed
@GitHK GitHK deleted the pr-osparc-more-space-for-building-images branch October 1, 2024 11:40
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants