-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 archiving_utils creates deterministic zip archives #6472
🐛 archiving_utils creates deterministic zip archives #6472
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6472 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.3%
=========================================
Files 10 1215 +1205
Lines 214 53197 +52983
Branches 25 1096 +1071
=========================================
+ Hits 181 46769 +46588
- Misses 23 6237 +6214
- Partials 10 191 +181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
When @giancarloromeo reviews it, since @sanderegg is not here, i can force-merge it when you tell me
…arc-simcore-forked into pr-osparc-reporducible-zipfile
Quality Gate passedIssues Measures |
…6472) Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
When creating a zip archive its hash would not be the same if ran twice on the same input files. Reasons:
These changes make it so that the produced archive will be deterministic. This allows different python interpreters to produce the same archive out of the same files (if their content does not change).
Related issue/s
How to test
Dev-ops checklist