Adding favicon for all devices #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsaq007
requested review from
GitHK,
mrnicegyu11,
mguidon,
sanderegg and
matusdrobuliak66
odeimaiz
approved these changes
Sep 25, 2024
You have a point except it uses the png or at least should. I will look and delete the svg as well unless it's needed elsewhere? |
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Odei Maiz <[email protected]>
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix favicon flickering and wrong favicon when duplicating tab, by including the write favicon in the index.html instead of updating it after loading the page
Related issue/s
fixes ITISFoundation/osparc-issues#1716
How to test
Dev-ops checklist