Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] TIP: Rebranding #6446

Merged
merged 14 commits into from
Sep 26, 2024
Merged

🎨 [Frontend] TIP: Rebranding #6446

merged 14 commits into from
Sep 26, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 25, 2024 •
edited
Loading

What do these changes do?

required by @calys

From now on, until further notice, the display names will be: TIP V3.0 and TIP.lite.

This PR removes the hardcoded TIP lites and relies on the display name coming from the DB. It also updates the tab labels which need to be hardcoded.

TIP lite

Related issue/s

related to ITISFoundation/osparc-issues#1701

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 25, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 25, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 25, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) September 25, 2024 13:34
GitHK
GitHK approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

services/static-webserver/client/source/resource/osparc/new_studies.json Outdated Show resolved Hide resolved
jsaq007
jsaq007 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz
Copy link
Member Author

@GitHK @pcrespov @jsaq007

I finally went for the ${token_key} approach 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz requested a review from jsaq007 September 26, 2024 07:17
jsaq007
jsaq007 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me 👍🏼

@odeimaiz odeimaiz merged commit 212a4ee into ITISFoundation:master Sep 26, 2024
51 of 52 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] TIP: Rebranding (ITISFoundation#6446)
bd45d6b
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@calys calys Awaiting requested review from calys

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @matusdrobuliak66