-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 improve error handling on pricing plans #6436
🎨 improve error handling on pricing plans #6436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6436 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.4%
=========================================
Files 10 362 +352
Lines 214 18106 +17892
Branches 25 0 -25
=========================================
+ Hits 181 15939 +15758
- Misses 23 2167 +2144
+ Partials 10 0 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a small test that verifies that this errors are raised? You can reuse it for future tests.
You can mock e.g. the response of the catalog. There are some mocks available
Quality Gate passedIssues Measures |
ccdeff2
into
ITISFoundation:master
What do these changes do?
Related issue/s
How to test
Dev-ops checklist