-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Persistent logs when GC removes services #6403
🎨 Persistent logs when GC removes services #6403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6403 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.3%
=========================================
Files 10 1172 +1162
Lines 214 51692 +51478
Branches 25 930 +905
=========================================
+ Hits 181 45452 +45271
- Misses 23 6065 +6042
- Partials 10 175 +165
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/web/server/src/simcore_service_webserver/garbage_collector/_core_disconnected.py
Outdated
Show resolved
Hide resolved
I would like to follow up a bit with you on this. IMO the GC services in similar in many ways to the autoscaler service in the sense that it observes to get a state and acts on it. There @sanderegg used several techniques to monitor the activity of the service by combining informative logs with prometheus metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
services/web/server/src/simcore_service_webserver/garbage_collector/plugin.py
Outdated
Show resolved
Hide resolved
…-service-shutdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are not using correctly caplog
. See the example i attach
Take advantage and add more informative logs
Quality Gate passedIssues Measures |
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
Changes log level for the
garbage_collector
to be set to INFO regardless of the global flagQuestion:
Why not put the log level to debug?
this never works, tried it multiple times and it always somehow reverts back to something else.As a developer, when trying to answer users' questions like:
Why has my service closed?
I want to quickly and reliably check the logs and figure out if their project was closed by the GC.Related issue/s
How to test
Dev-ops checklist