♻️CI: increase timeout on autoscaling to fix mypy slowness #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
t:maintenance
|
pcrespov
approved these changes
Sep 17, 2024
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
MyPy'ing autoscaling service takes a very long time. I could not really find why it is taking sooo much time, but it does not like the structure of autoscaling code, which is not that big.
I guess one other option could be to keep the mypy cache between CI runs, as running mypy a second time goes orders of magnitudes faster.
For now the timeout on autoscaling is increased by 1 minute.
Related issue/s
How to test
Dev-ops checklist