Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 do not allow moving folder to a child folder #6370

Conversation

matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 do not allow moving folder to a child folder

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 16, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Doppelbock milestone Sep 16, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 16, 2024 13:31
Copy link

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a german I love regulations that disallow stuff 💯

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.5%. Comparing base (cafbf96) to head (e701413).
Report is 543 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6370      +/-   ##
=========================================
- Coverage    84.5%   82.5%    -2.1%     
=========================================
  Files          10     591     +581     
  Lines         214   30246   +30032     
  Branches       25     260     +235     
=========================================
+ Hits          181   24953   +24772     
- Misses         23    5233    +5210     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.6% <27.2%> (?)
unittests 88.0% <100.0%> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../simcore_service_webserver/folders/_folders_api.py 90.8% <100.0%> (ø)
...c/simcore_service_webserver/folders/_folders_db.py 97.3% <100.0%> (ø)
...ore_service_webserver/folders/_folders_handlers.py 93.5% <100.0%> (ø)
...er/src/simcore_service_webserver/folders/errors.py 100.0% <100.0%> (ø)

... and 597 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 merged commit f272c8f into ITISFoundation:master Sep 16, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the bugfix/moving-between-folders branch September 16, 2024 14:23
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants