Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨🐛 [Frontend] Folders tree: improvements #6360

Merged
merged 20 commits into from
Sep 16, 2024
Merged

🎨🐛 [Frontend] Folders tree: improvements #6360

merged 20 commits into from
Sep 16, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 13, 2024 •
edited by pcrespov
Loading

What do these changes do?

  • Cancel Ignore obsolete /projects responses: If you switch fast between folders or workspaces, you might see the wrong (last call's) content. Still not perfect but improves the current state
  • Do not show plus buttons if user has no write access on workspace

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 13, 2024
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Sep 13, 2024
@odeimaiz odeimaiz added this to the Doppelbock milestone Sep 13, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 16, 2024 08:02
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected labels Sep 16, 2024
sanderegg
sanderegg reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) September 16, 2024 08:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit c21b1fb into ITISFoundation:master Sep 16, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2024
Closed
29 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg