Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 add running_time_in_hours to /services/-/aggregated-usages #6350

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 11, 2024

What do these changes do?

  • 🎨 add running_time_in_hours to /services/-/aggregated-usages

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 11, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 11, 2024 16:24
@matusdrobuliak66 matusdrobuliak66 added this to the Eisbock milestone Sep 11, 2024
Copy link

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.8%. Comparing base (cafbf96) to head (8613140).
Report is 530 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6350      +/-   ##
=========================================
+ Coverage    84.5%   88.8%    +4.2%     
=========================================
  Files          10    1218    +1208     
  Lines         214   53684   +53470     
  Branches       25     865     +840     
=========================================
+ Hits          181   47699   +47518     
- Misses         23    5854    +5831     
- Partials       10     131     +121     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 86.5% <100.0%> (+1.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...api_schemas_resource_usage_tracker/service_runs.py 100.0% <100.0%> (ø)
...ge_tracker/models/resource_tracker_service_runs.py 100.0% <100.0%> (ø)
...racker/modules/db/repositories/resource_tracker.py 75.7% <ø> (ø)
..._tracker/services/resource_tracker_service_runs.py 100.0% <ø> (ø)

... and 1201 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 add aggregation of time 🎨 add running_time_in_hours to /services/-/aggregated-usages Sep 11, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 merged commit 1692f4b into ITISFoundation:master Sep 12, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the add-time-aggreggation-billing-summary branch September 12, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend: Add aggregated time in the credits summary view
4 participants