Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Workspaces & Folders: Show them as a tree #6343

Merged
merged 16 commits into from
Sep 11, 2024
Merged

🎨 [Frontend] Workspaces & Folders: Show them as a tree #6343

merged 16 commits into from
Sep 11, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 10, 2024 •
edited
Loading

What do these changes do?

Feedback from meeting:

  • Show them as a tree
  • Remove the My Studies and Shared Studies filters

ToDo: Make the tree pretty

Tree

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review September 10, 2024 15:48
@odeimaiz odeimaiz self-assigned this Sep 10, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Sep 10, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 10, 2024
matusdrobuliak66
matusdrobuliak66 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) September 10, 2024 16:38
pcrespov
pcrespov reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

sanderegg
sanderegg reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

GitHK
GitHK approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for now, looking forward to the pretty ✨ version

@calys
Copy link

calys commented Sep 11, 2024

Very nice!

Just a couple of remarks:

  • it looks like navigation will become clumsy as soon as there are several levels of nested folders (because the user will have to use both the horizontal and the vertical scroll bar). Windows Explorer addresses that issue by 1. not having a horizontal scroll bar, 2. having a smaller indent between different nested folder levels, 3. allowing resizing the entire column.
  • the height of the folder navigation area quickly becomes too small. The tags end up taking most of the vertical space. Maybe they could float? or be moved somewhere else?

@odeimaiz
Copy link
Member Author

ToDo: Make the tree pretty

Thanks for the feedback. As mentioned in the description: "ToDo: Make the tree pretty"

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg disabled auto-merge September 11, 2024 08:36
@sanderegg sanderegg merged commit 9de4d19 into ITISFoundation:master Sep 11, 2024
51 checks passed
This was referenced Sep 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@ignapas ignapas Awaiting requested review from ignapas

@calys calys Awaiting requested review from calys

@AntoninoMarioC AntoninoMarioC Awaiting requested review from AntoninoMarioC

@newton1985 newton1985 Awaiting requested review from newton1985

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Eisbock
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @calys @GitHK @pcrespov @sanderegg @matusdrobuliak66