-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 adjust storage user project permission based on new logic with workspaces #6337
🐛 adjust storage user project permission based on new logic with workspaces #6337
Conversation
…liak66/osparc-simcore into listing-files-with-workspaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no tests?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6337 +/- ##
=========================================
- Coverage 84.5% 82.8% -1.8%
=========================================
Files 10 628 +618
Lines 214 32025 +31811
Branches 25 260 +235
=========================================
+ Hits 181 26529 +26348
- Misses 23 5436 +5413
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PLease add an issue and tag/classify it appropriately so we do not miss this. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease add an issue and tag/classify it appropriately so we do not miss this. thx
and I align as well with @sanderegg , is this covered by any test?
test added 👍 |
|
What do these changes do?
Related issue/s
How to test
Dev-ops checklist