Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adjust storage user project permission based on new logic with workspaces #6337

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 10, 2024

What do these changes do?

  • 🐛 adjust storage user project permission based on new logic with workspaces
    • This endpoint needs to be refactored, and we also need to add pagination. For now, I am making it backward-compatible so that it also lists projects the user has access to through shared workspaces.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 fix storage project permissions 🐛 adjust storage user project permission based on new logic with workspaces Sep 10, 2024
@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 10, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Eisbock milestone Sep 10, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 10, 2024 11:43
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests?

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (cafbf96) to head (12f1146).
Report is 524 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6337      +/-   ##
=========================================
- Coverage    84.5%   82.8%    -1.8%     
=========================================
  Files          10     628     +618     
  Lines         214   32025   +31811     
  Branches       25     260     +235     
=========================================
+ Hits          181   26529   +26348     
- Misses         23    5436    +5413     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.5% <ø> (?)
unittests 88.1% <100.0%> (+3.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...age/src/simcore_service_storage/db_access_layer.py 88.7% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 97.8% <ø> (ø)
...ore_service_webserver/workspaces/_workspaces_db.py 96.7% <ø> (ø)

... and 635 files with indirect coverage changes

@pcrespov
Copy link
Member

  • This endpoint needs to be refactored, and we also need to add pagination. For now, I am making it backward-compatible so that it also lists projects the user has access to through shared workspaces.

PLease add an issue and tag/classify it appropriately so we do not miss this. thx

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease add an issue and tag/classify it appropriately so we do not miss this. thx
and I align as well with @sanderegg , is this covered by any test?

@matusdrobuliak66
Copy link
Contributor Author

no tests?

test added 👍

Copy link

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 11, 2024 06:59
@matusdrobuliak66 matusdrobuliak66 merged commit 0722af4 into ITISFoundation:master Sep 11, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the listing-files-with-workspaces branch September 11, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants