Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RUT port envs ⚠️ [DEVOPS] #6300

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Sep 4, 2024

What do these changes do?

These changes allow configuration of resource-usage-tracker port. It also brings a distinction between "internal" (FASTAPI's) and "external" (reachable from other services) ports

Related issue/s

How to test

Dev-ops checklist

@YuryHrytsuk YuryHrytsuk added the a:resource-usage-tracker resource usage tracker service label Sep 4, 2024
@YuryHrytsuk YuryHrytsuk added this to the Eisbock milestone Sep 4, 2024
@YuryHrytsuk YuryHrytsuk self-assigned this Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (cafbf96) to head (166c52d).
Report is 501 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6300      +/-   ##
=========================================
+ Coverage    84.5%   86.2%    +1.6%     
=========================================
  Files          10    1495    +1485     
  Lines         214   61722   +61508     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53226   +53045     
- Misses         23    8196    +8173     
- Partials       10     300     +290     
Flag Coverage Δ
unittests 86.2% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1442 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) September 4, 2024 07:05
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@YuryHrytsuk YuryHrytsuk requested a review from pcrespov September 4, 2024 07:36
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright thx!

Copy link

sonarqubecloud bot commented Sep 4, 2024

@YuryHrytsuk YuryHrytsuk merged commit 22ff9da into ITISFoundation:master Sep 4, 2024
55 of 56 checks passed
@YuryHrytsuk YuryHrytsuk deleted the rut-add-port-env branch September 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes: aws master simcore resource usage tracker
4 participants