Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add product_name to folders table #6124

Merged
merged 13 commits into from
Aug 1, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 31, 2024

What do these changes do?

Added missing product_name to products table.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jul 31, 2024
@GitHK GitHK added the a:database associated to postgres service and postgres-database package label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.7%. Comparing base (cafbf96) to head (c5793b4).
Report is 393 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6124      +/-   ##
=========================================
+ Coverage    84.5%   88.7%    +4.1%     
=========================================
  Files          10    1256    +1246     
  Lines         214   52784   +52570     
  Branches       25     669     +644     
=========================================
+ Hits          181   46833   +46652     
- Misses         23    5803    +5780     
- Partials       10     148     +138     
Flag Coverage Δ
integrationtests 53.5% <ø> (?)
unittests 86.9% <100.0%> (+2.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...se/src/simcore_postgres_database/models/folders.py 100.0% <ø> (ø)
...ase/src/simcore_postgres_database/utils_folders.py 96.7% <100.0%> (ø)

... and 1223 files with indirect coverage changes

@GitHK GitHK added this to the Tom Bombadil milestone Jul 31, 2024
@GitHK GitHK marked this pull request as ready for review July 31, 2024 08:37
@GitHK GitHK requested a review from matusdrobuliak66 as a code owner July 31, 2024 08:37
@GitHK GitHK requested a review from sanderegg July 31, 2024 08:37
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Please check my comment and re-use instead of re-create. we really need to reduce complexity.

packages/postgres-database/tests/test_utils_folders.py Outdated Show resolved Hide resolved
@GitHK GitHK enabled auto-merge (squash) August 1, 2024 07:46
Copy link

sonarqubecloud bot commented Aug 1, 2024

@GitHK GitHK merged commit 48e2791 into ITISFoundation:master Aug 1, 2024
56 checks passed
@GitHK GitHK deleted the pr-osparc-add-product-to-folders branch August 1, 2024 08:16
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants