Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] UX: Reuse Add collaborators widget in Publish template #6058

Merged
merged 34 commits into from
Jul 16, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 12, 2024

What do these changes do?

In order to improve the Publish Template UX, this PR refactors the Publish Template view and reuses the Share With widgets.

Bonus:

Bugfix: found the signal that was sometimes requesting the creation of two templates

Now:
PublishNew

Before:
PublishBefore

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jul 12, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 12, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jul 12, 2024
@odeimaiz odeimaiz marked this pull request as ready for review July 15, 2024 13:54
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 15, 2024 13:54
@odeimaiz odeimaiz enabled auto-merge (squash) July 15, 2024 14:54
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit db64ca3 into ITISFoundation:master Jul 16, 2024
50 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants