Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Bugfix: Required inputs #6013

Merged
merged 8 commits into from
Jul 1, 2024
Merged

🐛 [Frontend] Bugfix: Required inputs #6013

merged 8 commits into from
Jul 1, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 28, 2024 •
edited
Loading

What do these changes do?

Found during the NIH demo, when making an input required, in some scenarios, the required input port was marked as required in all nodes in the workbench. This PR fixes it.

Bonus:

  • [Fix] Study data Reload button: reset cached data before repopulating tree.
  • [Fix] Shared with me filter: the shared with me filter was only filtering that were directly "shared with me", without taking into account those that were shared through an organization.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jun 28, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 28, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jun 28, 2024
@odeimaiz odeimaiz marked this pull request as ready for review June 28, 2024 15:27
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 28, 2024 15:27
@odeimaiz odeimaiz enabled auto-merge (squash) June 28, 2024 15:27
pcrespov
pcrespov reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elisabettai
elisabettai approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Wow, cool, now the "Shared with me" also show things shared via an Organization, I thought that was much harder to implement. ☺️

@odeimaiz
Copy link
Member Author

odeimaiz commented Jul 1, 2024 •
edited
Loading

Thanks!

Wow, cool, now the "Shared with me" also show things shared via an Organization, I thought that was much harder to implement. ☺️

Well... If it's not mine and it isn't shared with Everyone, but it is still listed by the backend, I assume it was shared with me 👍

@odeimaiz odeimaiz merged commit 7ef7cc5 into ITISFoundation:master Jul 1, 2024
49 of 50 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 4, 2024
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@jsaq007 jsaq007 jsaq007 approved these changes

@GitHK GitHK GitHK approved these changes

@elisabettai elisabettai elisabettai approved these changes

@sanderegg sanderegg sanderegg approved these changes

@ignapas ignapas Awaiting requested review from ignapas

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @GitHK @elisabettai @pcrespov @sanderegg