-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Storage: fix database locking #6005
🐛Storage: fix database locking #6005
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6005 +/- ##
=========================================
+ Coverage 84.5% 87.7% +3.2%
=========================================
Files 10 1330 +1320
Lines 214 55249 +55035
Branches 25 1368 +1343
=========================================
+ Hits 181 48501 +48320
- Misses 23 6465 +6442
- Partials 10 283 +273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
622d65c
to
4b84a0d
Compare
49c416c
to
b822993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx a lot! I am looking forward to check this fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
b822993
to
d0bd3a3
Compare
017ef9f
to
1a31807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Just a few comments/questions from my side
What do these changes do?
This PR aims at removing all unbounded database connection locks in storage
Details
Related issue/s
How to test
Dev-ops checklist