-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🐛 [Frontend] Reuse iframe starting sequence for guests #6004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
I also want to see the trick to tune the voila loading messages. 🤩
Add the following cell before running the cell that is going to take long
Here we just change the text, but you could also add some fancy HTML 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
The Dynamic Service starting sequence (poll state, show loading sequence, handle errors, switch to iframe's content...) wasn't the same for logged in users and guest users. This PR unifies the code related to it.
Bonus:
Switch to Voila loading content, instead of staying at the Ready loading page, without waiting for the native "load" event.
@Konohana0608 I also found the way to tune the
Running 2 of 5...
loading voila message. Notice theSleeping for 30"
message:Related issue/s
How to test
Dev-ops checklist