Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🐛 [Frontend] Reuse iframe starting sequence for guests #6004

Merged
merged 29 commits into from
Jul 1, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 27, 2024

What do these changes do?

The Dynamic Service starting sequence (poll state, show loading sequence, handle errors, switch to iframe's content...) wasn't the same for logged in users and guest users. This PR unifies the code related to it.

Bonus:
Switch to Voila loading content, instead of staying at the Ready loading page, without waiting for the native "load" event.

@Konohana0608 I also found the way to tune the Running 2 of 5... loading voila message. Notice the Sleeping for 30" message:

VoilaMessages

Guest

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jun 27, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 27, 2024
@odeimaiz odeimaiz self-assigned this Jun 27, 2024
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Shared with me filter ♻️🐛 [Frontend] Reuse node starting sequence for guests Jun 27, 2024
@odeimaiz odeimaiz changed the title ♻️🐛 [Frontend] Reuse node starting sequence for guests ♻️🐛 [Frontend] Reuse iframe sequence for guests Jun 27, 2024
@odeimaiz odeimaiz changed the title ♻️🐛 [Frontend] Reuse iframe sequence for guests ♻️🐛 [Frontend] Reuse iframe starting sequence for guests Jun 27, 2024
@odeimaiz odeimaiz marked this pull request as ready for review June 28, 2024 09:26
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 28, 2024 09:26
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!
I also want to see the trick to tune the voila loading messages. 🤩

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 28, 2024

Very nice, thanks! I also want to see the trick to tune the voila loading messages. 🤩

@elisabettai

Add the following cell before running the cell that is going to take long

%%js
const loadingTextEl = document.getElementById("loading_text");
loadingTextEl ? loadingTextEl.innerText = 'This task is going to take very long' : null;

Here we just change the text, but you could also add some fancy HTML 👌

@odeimaiz odeimaiz enabled auto-merge (squash) June 28, 2024 13:27
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 5c3a6bf into ITISFoundation:master Jul 1, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants