Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Frontend] Coins icon for the credits indicator #5993

Merged
merged 25 commits into from
Jun 26, 2024
Merged

✨ [Frontend] Coins icon for the credits indicator #5993

merged 25 commits into from
Jun 26, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 25, 2024 •
edited
Loading

What do these changes do?

This PR replaces the database icon used for the credits indicator with the coins icons.

A widget that displays any SVG image and supports changing its color (css filter 😱 ) had to be implemented.

Coins

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jun 25, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 25, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 25, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] SVGImage widget ✨ [Frontend] Coins icon for the credits indicator Jun 25, 2024
@odeimaiz odeimaiz marked this pull request as ready for review June 26, 2024 06:04
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 26, 2024 06:04
jsaq007
jsaq007 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer. Thanks

elisabettai
elisabettai approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🤩
General comment: if we start to use more and more svgs, it might make sense to move them to the assets repo. E.g. we often use the osparc logo in presentations, but where it is now is quite hidden...

pcrespov
pcrespov reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪙 !

@odeimaiz odeimaiz enabled auto-merge (squash) June 26, 2024 10:20
@odeimaiz odeimaiz merged commit 25fbe83 into ITISFoundation:master Jun 26, 2024
50 checks passed
@GitHK GitHK mentioned this pull request Jul 1, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@Konohana0608 Konohana0608 Awaiting requested review from Konohana0608

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @ignapas @GitHK @elisabettai @pcrespov