-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [Frontend] Fix: From service running to connect to iframe #5987
Merged
odeimaiz
merged 7 commits into
ITISFoundation:master
from
odeimaiz:fix/running-to-iframe
Jun 24, 2024
Merged
🐛 [Frontend] Fix: From service running to connect to iframe #5987
odeimaiz
merged 7 commits into
ITISFoundation:master
from
odeimaiz:fix/running-to-iframe
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
buggy, it does not work as expected
a:frontend
issue affecting the front-end (area group)
labels
Jun 21, 2024
odeimaiz
changed the title
🐛 [Frontend] Fix: From running to iframe
🐛 [Frontend] Fix: From service running to connect to iframe
Jun 21, 2024
pcrespov
reviewed
Jun 21, 2024
services/static-webserver/client/source/class/osparc/data/model/Node.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Node.js
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
GitHK
approved these changes
Jun 24, 2024
jsaq007
approved these changes
Jun 24, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Retry a maximum of 40 times with a 5" interval to connect to the backend
Related issue/s
How to test
Dev-ops checklist