-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Enhance diagnostics info in e2e testing #5962
🔨 Enhance diagnostics info in e2e testing #5962
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5962 +/- ##
=========================================
- Coverage 84.5% 62.9% -21.6%
=========================================
Files 10 462 +452
Lines 214 23584 +23370
Branches 25 0 -25
=========================================
+ Hits 181 14856 +14675
- Misses 23 8728 +8705
+ Partials 10 0 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
ba583f8
to
104e365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice and simple addition.
Question: will it print it on failure only? and when? at the end or at the beginning of the logs? or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci
This reverts commit 104e365.
104e365
to
15b0946
Compare
|
What do these changes do?
This PR does some changes in the e2e-playwritght tests
Related issue/s
How to test
This is how it would display in case of failure
Dev-ops checklist
None