-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨E2E: improvements on ClassicTIP test #5955
🎨E2E: improvements on ClassicTIP test #5955
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5955 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.3%
=========================================
Files 10 1324 +1314
Lines 214 55193 +54979
Branches 25 1340 +1315
=========================================
+ Hits 181 48539 +48358
- Misses 23 6368 +6345
- Partials 10 286 +276
Flags with carried forward coverage won't be shown. Click here to find out more. |
45852b0
to
80abfa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort 👍
I would move the _trigger_next_app
function out of the wait_for_service_running
function and bring it back to the test_ti_plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing effort, thanks a lot!
It looks like this test is becoming much more robust and easier to debug!
8e7a245
to
2e6e812
Compare
What do these changes do?
make test-tip-anywhere
)Bonus:
Related issue/s
How to test
Dev-ops checklist