Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨E2E: improvements on ClassicTIP test #5955

Merged
merged 44 commits into from
Jun 20, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 17, 2024

What do these changes do?

  • refactored ClassicTI e2e test
  • use websocket events and expected requests to better check when actions are completed
  • added makefile target to easily run the tip_plan tests (make test-tip-anywhere)
  • renamed to test_tip_plan.py to follow pytest best practices -> requires updates in e2e-backend repo
  • now autoscaled system compatible (works against tip.science)
  • exceptions in context are now showing the trace (makes debugging much easier)

Bonus:

  • fixed monitoring clusters to be compatible with tip.science ssh key pattern
  • removed makefile and drawio extension from recommended list as this was plagging vscode

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jun 17, 2024
@sanderegg sanderegg added this to the South Island Iced Tea milestone Jun 17, 2024
@sanderegg sanderegg self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.9%. Comparing base (cafbf96) to head (347013d).
Report is 284 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5955      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1324    +1314     
  Lines         214   55193   +54979     
  Branches       25    1340    +1315     
=========================================
+ Hits          181   48539   +48358     
- Misses         23    6368    +6345     
- Partials       10     286     +276     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 85.8% <ø> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1284 files with indirect coverage changes

@sanderegg sanderegg force-pushed the e2e/improve-tip-testing branch 3 times, most recently from 45852b0 to 80abfa5 Compare June 19, 2024 06:38
@sanderegg sanderegg marked this pull request as ready for review June 19, 2024 09:29
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! thx

tests/e2e-playwright/tests/sleepers/sleepers.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/ti_plan/test_ti_plan.py Outdated Show resolved Hide resolved
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort 👍

I would move the _trigger_next_app function out of the wait_for_service_running function and bring it back to the test_ti_plan

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort, thanks a lot!
It looks like this test is becoming much more robust and easier to debug! ☺️

@sanderegg sanderegg force-pushed the e2e/improve-tip-testing branch from 8e7a245 to 2e6e812 Compare June 20, 2024 07:48
@sanderegg sanderegg merged commit 81b6bd2 into ITISFoundation:master Jun 20, 2024
56 checks passed
@sanderegg sanderegg deleted the e2e/improve-tip-testing branch June 20, 2024 09:11
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants