Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor stop service command ⚠️🚨 #5924

Merged
merged 11 commits into from
Jun 7, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 7, 2024

⚠️ Dev-ops

This code has to be deployed with all dynamic-services stopped. The service stop API from webserver-> dynamic-scheduler changed in a backwards incompatible way.

What do these changes do?

Adds project_id and user_id to the stop command sent to the dynamic-scheduler. These changes are required to cover an edge case: enables stopping a service that is not tracked by the scheduler.

These changes are part of #5892

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.5%. Comparing base (cafbf96) to head (4a3c16b).
Report is 259 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5924      +/-   ##
=========================================
+ Coverage    84.5%   87.5%    +2.9%     
=========================================
  Files          10    1223    +1213     
  Lines         214   53363   +53149     
  Branches       25    1072    +1047     
=========================================
+ Hits          181   46709   +46528     
- Misses         23    6419    +6396     
- Partials       10     235     +225     
Flag Coverage Δ
integrationtests 63.5% <100.0%> (?)
unittests 85.5% <100.0%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../api_schemas_dynamic_scheduler/dynamic_services.py 100.0% <100.0%> (ø)
...bitmq/rpc_interfaces/dynamic_scheduler/services.py 0.0% <ø> (ø)
...ore_service_dynamic_scheduler/api/rpc/_services.py 100.0% <100.0%> (ø)
...c_scheduler/services/director_v2/_public_client.py 92.0% <100.0%> (ø)
...mic_scheduler/services/director_v2/_thin_client.py 100.0% <ø> (ø)
...simcore_service_webserver/dynamic_scheduler/api.py 88.3% <ø> (ø)
...rvice_webserver/garbage_collector/_core_orphans.py 100.0% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py 91.1% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 79.3% <ø> (ø)

... and 1201 files with indirect coverage changes

@GitHK GitHK changed the title ♻️ project_id and user_id to stop service command ♻️ refactor stop service command Jun 7, 2024
@GitHK GitHK marked this pull request as ready for review June 7, 2024 08:50
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ refactor stop service command ♻️ refactor stop service command ⚠️🚨 Jun 7, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I get why this change is needed. but I guess it will come with the next PR..

@GitHK GitHK force-pushed the pr-osparc-extend-stop-params branch from df061f3 to aa93e57 Compare June 7, 2024 09:47
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@sanderegg sanderegg merged commit d25082c into ITISFoundation:master Jun 7, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-extend-stop-params branch June 7, 2024 11:44
GitHK pushed a commit that referenced this pull request Jun 20, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants