-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor stop service command ⚠️🚨 #5924
♻️ refactor stop service command ⚠️🚨 #5924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5924 +/- ##
=========================================
+ Coverage 84.5% 87.5% +2.9%
=========================================
Files 10 1223 +1213
Lines 214 53363 +53149
Branches 25 1072 +1047
=========================================
+ Hits 181 46709 +46528
- Misses 23 6419 +6396
- Partials 10 235 +225
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I get why this change is needed. but I guess it will come with the next PR..
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_scheduler/services.py
Outdated
Show resolved
Hide resolved
df061f3
to
aa93e57
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 💯
This code has to be deployed with all dynamic-services stopped. The service stop API from
webserver
->dynamic-scheduler
changed in a backwards incompatible way.What do these changes do?
Adds
project_id
anduser_id
to the stop command sent to thedynamic-scheduler
. These changes are required to cover an edge case: enables stopping a service that is not tracked by the scheduler.These changes are part of #5892
Related issue/s
dynamic-scheduler
pushes service state to the frontend (⚠️ devops) #5892How to test
Dev-ops checklist