-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor RedisClientsManager
and RedisClientSDK
#5888
♻️ refactor RedisClientsManager
and RedisClientSDK
#5888
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5888 +/- ##
=========================================
+ Coverage 84.5% 87.5% +2.9%
=========================================
Files 10 1110 +1100
Lines 214 48293 +48079
Branches 25 716 +691
=========================================
+ Hits 181 42261 +42080
- Misses 23 5872 +5849
- Partials 10 160 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check @pcrespov comments.
@sanderegg @pcrespov I had to rework this PR a bit, please read the updated description again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some early comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. If some of the feedback is unclear, please let me know if you prefer to discuss offline
…ager-health-checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some more comments. I don't get why your new class needs a init function since it is a dataclass.
Also, I would prefer that we don't have 2 different clients but just 1. is it not possible to migrate the dynamic sidecar one, and just keep one simple client?
RedisClientsManager
and RedisClientSDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
@GitHK requested a force merge |
What do these changes do?
decode_responses
toRedisClientSDK
RedisClientsManager
initialisation changed to allow for overwriting of default values used in the constructor ofRedisClientSDK
RedisClientSDK
clients now expose the health of the connection to Redis.HealthCheckedRedisClientSDK
and merged withRedisClientSDK
Related issue/s
dynamic-scheduler
pushes service state to the frontend (⚠️ devops) #5892How to test
Dev-ops checklist