-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is539/master build fails #540
Merged
pcrespov
merged 7 commits into
ITISFoundation:master
from
pcrespov:is539/master-build-fails
Jan 29, 2019
Merged
Is539/master build fails #540
pcrespov
merged 7 commits into
ITISFoundation:master
from
pcrespov:is539/master-build-fails
Jan 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added workaround for pypa/pip#6197 - Froze python2 requirements (virtualenv py2.7 would fail to install numpy)
Changes to be committed: new file: services/storage/requirements/py27.in modified: services/storage/requirements/py27.txt
pcrespov
pushed a commit
to pcrespov/cookiecutter-simcore-pyservice
that referenced
this pull request
Jan 28, 2019
Cleans up Dockerfile target `cache`
2 tasks
sanderegg
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool there is a fix!
odeimaiz
approved these changes
Jan 29, 2019
ghost
removed
the
review
label
Jan 29, 2019
pcrespov
added a commit
to ITISFoundation/cookiecutter-simcore-pyservice
that referenced
this pull request
Feb 1, 2019
* Adds pip workaround as in ITISFoundation/osparc-simcore#540 Cleans up Dockerfile target `cache` * Flipped position of 'development' target in Dockerfile to speed up image build of production targets during CI. Now development is a bit slower * Adds fixes for .pipcache workaround so that it does not fail in devmode Changes to be committed: modified: {{cookiecutter.project_slug}}/Dockerfile * renamed integration -> _osparc-simcore folder * Fixes typo in README rendering Minor * Uninstalls in production stage all dev tools * output folder has osparc-simcore-like folder structure * Minor: alias target in makefile and added pre-gen hook as sample * Fixes test failure * to log or not to logger ...? * Added health-check command and script for service * Minors in Makefile * cleaned up template Makefile and added usage in README.md * Fixes setup naming * Adds setup_swagger to display API documentation * Added exceptions pckage
pcrespov
added a commit
to ITISFoundation/cookiecutter-simcore-pyservice
that referenced
this pull request
Apr 3, 2019
* Adds pip workaround as in ITISFoundation/osparc-simcore#540 Cleans up Dockerfile target `cache` * Flipped position of 'development' target in Dockerfile to speed up image build of production targets during CI. Now development is a bit slower * Adds fixes for .pipcache workaround so that it does not fail in devmode Changes to be committed: modified: {{cookiecutter.project_slug}}/Dockerfile * renamed integration -> _osparc-simcore folder * Fixes typo in README rendering Minor * Uninstalls in production stage all dev tools * output folder has osparc-simcore-like folder structure * Minor: alias target in makefile and added pre-gen hook as sample * Fixes test failure * to log or not to logger ...? * Added health-check command and script for service * Minors in Makefile * cleaned up template Makefile and added usage in README.md * Fixes setup naming * Adds setup_swagger to display API documentation * Added exceptions pckage * Added microbadger badges for images * Added banners for released docker images * updated healtcheck * Upgrading Dockerfile to deal with non-root users (ITISFoundation/osparc-simcore#90) * Updated entrypoint and boot as well as docker-compose and .dockerignor * Updated doc to underline new features * Adapting travis to run docker tests * Added make target to build prod docker * Disabled docker-build * Minor fixes * Fixing app console path * Simplified PR message * Fixes on docker configs after creating webserver and storage services * minor fixes and doc added folder for integration tests WIP * Disabled client-sdk * Moved client-sdk and integration tests to keep folder * Renamed as 'stub' * Cleaned up cookiecutter attributes list * Removed all references to docker in the Makefile * fix exit code * Fixes development mode in windows where docker mounts all volumes as root * literal user name instead of variable * Changend environment variables prefix Simplified healthcheck * Minor linter * Fix issue when docker group name already exists * REview: disabled all todos and other minor * Added test to check for tags in all generated files * Review: reduced timeout * Cleanedup readme * Fixes test and minor changes * fixes tests * Review: commented out installed packages in Dockerfile * fixed TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes master CI build (see #539)
--no-cache-dir
option and adding explicit cache directory that is then removed at the end of the image build:Related issue number
fixes #539
Checklist