Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is539/master build fails #540

Merged
merged 7 commits into from
Jan 29, 2019

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 28, 2019

What do these changes do?

Fixes master CI build (see #539)

pip --cache-dir=/pipcache ...
rm -rf /pipcache
  • Froze services/storage/requirements/py27.txt to avoid error with numpy dependencies

Related issue number

fixes #539

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@ghost ghost assigned pcrespov Jan 28, 2019
@ghost ghost added the review label Jan 28, 2019
@pcrespov pcrespov requested review from sanderegg and mguidon January 28, 2019 17:00
 Changes to be committed:
	new file:   services/storage/requirements/py27.in
	modified:   services/storage/requirements/py27.txt
pcrespov pushed a commit to pcrespov/cookiecutter-simcore-pyservice that referenced this pull request Jan 28, 2019
Cleans up Dockerfile target `cache`
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool there is a fix!

@pcrespov pcrespov requested a review from odeimaiz January 29, 2019 07:34
@pcrespov pcrespov merged commit 86bf015 into ITISFoundation:master Jan 29, 2019
@ghost ghost removed the review label Jan 29, 2019
@pcrespov pcrespov deleted the is539/master-build-fails branch January 29, 2019 09:22
pcrespov added a commit to ITISFoundation/cookiecutter-simcore-pyservice that referenced this pull request Feb 1, 2019
* Adds pip workaround as in  ITISFoundation/osparc-simcore#540
Cleans up Dockerfile target `cache`

* Flipped position of 'development' target in Dockerfile to speed up image build of production targets during CI. Now development is a bit slower

* Adds fixes for .pipcache workaround so that it does not fail in devmode
 Changes to be committed:
	modified:   {{cookiecutter.project_slug}}/Dockerfile

* renamed integration -> _osparc-simcore folder

* Fixes typo in README rendering
Minor

* Uninstalls in production stage all dev tools

* output folder has osparc-simcore-like folder structure

* Minor: alias target in makefile and added pre-gen hook as sample

* Fixes test failure

* to log or not to logger ...?

* Added health-check command and script for service

* Minors in Makefile

* cleaned up template Makefile and added usage in README.md

* Fixes setup naming

* Adds setup_swagger to display API documentation

* Added exceptions pckage
pcrespov added a commit to ITISFoundation/cookiecutter-simcore-pyservice that referenced this pull request Apr 3, 2019
* Adds pip workaround as in  ITISFoundation/osparc-simcore#540
Cleans up Dockerfile target `cache`

* Flipped position of 'development' target in Dockerfile to speed up image build of production targets during CI. Now development is a bit slower

* Adds fixes for .pipcache workaround so that it does not fail in devmode
 Changes to be committed:
	modified:   {{cookiecutter.project_slug}}/Dockerfile

* renamed integration -> _osparc-simcore folder

* Fixes typo in README rendering
Minor

* Uninstalls in production stage all dev tools

* output folder has osparc-simcore-like folder structure

* Minor: alias target in makefile and added pre-gen hook as sample

* Fixes test failure

* to log or not to logger ...?

* Added health-check command and script for service

* Minors in Makefile

* cleaned up template Makefile and added usage in README.md

* Fixes setup naming

* Adds setup_swagger to display API documentation

* Added exceptions pckage

* Added microbadger badges for images

* Added banners for released docker images

* updated healtcheck

* Upgrading Dockerfile to deal with non-root users (ITISFoundation/osparc-simcore#90)

* Updated entrypoint and boot as well as docker-compose and .dockerignor

* Updated doc to underline new features

* Adapting travis to run docker tests

* Added make target to build prod docker

* Disabled docker-build

* Minor fixes

* Fixing app console path

* Simplified PR message

* Fixes on docker configs after creating webserver and storage services

* minor fixes and doc
added folder for integration tests WIP

* Disabled client-sdk

* Moved client-sdk and integration tests to keep folder

* Renamed as 'stub'

* Cleaned up cookiecutter attributes list

* Removed all references to docker in the Makefile

* fix exit code

* Fixes development mode in windows where docker mounts all volumes as root

* literal user name instead of variable

* Changend environment variables prefix
Simplified healthcheck

* Minor linter

* Fix issue when docker group name already exists

* REview: disabled all todos and other minor

* Added test to check for tags in all generated files

* Review: reduced timeout

* Cleanedup readme

* Fixes test and minor changes

* fixes tests

* Review: commented out installed packages in Dockerfile

* fixed TODOs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix master CI build
3 participants