Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bugfix/e2e sim4life test #5219

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 9, 2024

What do these changes do?

  • 🐛 improving the catching pattern to get the created project uuid (before it can happen that it caught for example /projects/active endpoint)

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 9, 2024 09:43
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 9, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the This is Sparta! milestone Jan 9, 2024
tests/e2e-playwright/tests/sim4life.py Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 9, 2024 10:16
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744ff06) 87.9% compared to head (839e5a8) 56.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5219      +/-   ##
=========================================
- Coverage    87.9%   56.1%   -31.8%     
=========================================
  Files        1088      58    -1030     
  Lines       46412    2799   -43613     
  Branches     1026       0    -1026     
=========================================
- Hits        40804    1572   -39232     
+ Misses       5377    1227    -4150     
+ Partials      231       0     -231     
Flag Coverage Δ
integrationtests 56.1% <ø> (-8.9%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1068 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 merged commit f533257 into ITISFoundation:master Jan 9, 2024
54 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants