🎨 Beautify Buy credits #4945
Merged
🎨 Beautify Buy credits #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
odeimaiz
requested review from
jsaq007,
ignapas,
GitHK,
elisabettai,
pcrespov,
sanderegg,
matusdrobuliak66 and
mguidon
pcrespov
reviewed
Oct 27, 2023
There was a problem hiding this comment.
I would prefer to check with PR #4946 before you merge this one.
For instance
- the minimum threshold to top-up is defined in the backend and returned read-only in the auto-recharge info. ( you hard-coded 25 in the help)
- extra help on the monthly limit (perhaps an info button that shows more details or a link to a manual??)
elisabettai
approved these changes
Oct 30, 2023
matusdrobuliak66
approved these changes
Oct 30, 2023
ignapas
approved these changes
Oct 30, 2023
sanderegg
approved these changes
Oct 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit eb5e7da and detected 0 issues on this pull request. View more on Code Climate. |
jsaq007
reviewed
Oct 30, 2023
services/static-webserver/client/source/class/osparc/desktop/credits/AutoRecharge.js
Show resolved
Hide resolved
This was referenced Oct 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR prettifies the One Time Payment UI and it also redesigns the Auto Recharge one by updating the form fields and the UI.
One Time payment:
Auto recharge:
Related issue/s
How to test
DevOps Checklist