✨ Clusters keeper: add rpc methods to get EC2 instance capabilities #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4942 +/- ##
========================================
- Coverage 86.9% 83.2% -3.7%
========================================
Files 1205 979 -226
Lines 50169 43323 -6846
Branches 1074 534 -540
========================================
- Hits 43625 36075 -7550
- Misses 6308 7129 +821
+ Partials 236 119 -117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
approved these changes
Oct 27, 2023
packages/models-library/src/models_library/rpc_schemas_clusters_keeper/clusters.py
Outdated
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/ec2.py
Outdated
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/ec2.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
clusters-keeper/add-rpc-to-get-instance-capabilities
branch
from
a85f328 to
e3dfbd4
Compare
GitHK
approved these changes
Oct 30, 2023
added RPC method for getting EC2 instance types
sanderegg
force-pushed
the
clusters-keeper/add-rpc-to-get-instance-capabilities
branch
from
76f41d1 to
f793fdd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit f793fdd and detected 0 issues on this pull request. View more on Code Climate. |
sanderegg
deleted the
clusters-keeper/add-rpc-to-get-instance-capabilities
branch
This was referenced Oct 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR enhance the Clusters-keeper RPC interface to allow to get information about possible EC2 instance types and capabilities (for now RAM and CPUs)
In the next PR, this will be used from the director-v2 to fully use the underlying machine capacity
Related issue/s
How to test
cd services/clusters-keeper make install-dev make test-dev-unitDevOps Checklist