Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🐛 E2E: Check for any computational logs flowing + add check to sleepers and isolve-gpu tests #4940

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

sanderegg
Copy link
Member

What do these changes do?

This PR changes:

  • check for any log coming from the computational backend (logs starting with [sidecar] should always be present), this is proof that the connection from dask-worker --> dask-scheduler --> director-v2 --> rabbitmq --> webserver --> webclient is up and running (even if some messages are missing), this makes the test more resilient
  • the check is now done in:
  • sleepers (new)
  • isolve-mpi
  • isolve-gpu (new)

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Oct 27, 2023
@sanderegg sanderegg added this to the Microhistory milestone Oct 27, 2023
@sanderegg sanderegg self-assigned this Oct 27, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

@sanderegg sanderegg force-pushed the e2e/check-for-any-logs branch from 9d7a984 to f88cef9 Compare October 27, 2023 12:51
@sanderegg sanderegg force-pushed the e2e/check-for-any-logs branch from f88cef9 to 48f39c3 Compare October 27, 2023 12:56
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2023

Code Climate has analyzed commit 48f39c3 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm curious to see how this goes.

We also created this issue a while ago about missing logs (for another service). But I cannot reproduce it anymore.

@sanderegg
Copy link
Member Author

Thanks. I'm curious to see how this goes.

We also created this issue a while ago about missing logs (for another service). But I cannot reproduce it anymore.

@elisabettai yes the problem from that issue is still valid. the fix here just "makes the test green", by checking for any log coming from the computational backend instead of a very specific one. Since there should be many, then the chances are lower they are missing. Since the full log is always available in the service outputs, I deem the fact that it is missing from the UI a bit less problematic, since it anyway disappears if you refresh the page or go out of the study.

@sanderegg sanderegg enabled auto-merge (squash) October 27, 2023 13:06
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! super @sanderegg doing now javascript! Not surprised though ... ;-)

@sanderegg sanderegg merged commit 68081e2 into ITISFoundation:master Oct 27, 2023
@sanderegg sanderegg deleted the e2e/check-for-any-logs branch October 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants