-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🐛 E2E: Check for any computational logs flowing + add check to sleepers and isolve-gpu tests #4940
✨🐛 E2E: Check for any computational logs flowing + add check to sleepers and isolve-gpu tests #4940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot
9d7a984
to
f88cef9
Compare
f88cef9
to
48f39c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Code Climate has analyzed commit 48f39c3 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm curious to see how this goes.
We also created this issue a while ago about missing logs (for another service). But I cannot reproduce it anymore.
@elisabettai yes the problem from that issue is still valid. the fix here just "makes the test green", by checking for any log coming from the computational backend instead of a very specific one. Since there should be many, then the chances are lower they are missing. Since the full log is always available in the service outputs, I deem the fact that it is missing from the UI a bit less problematic, since it anyway disappears if you refresh the page or go out of the study. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! super @sanderegg doing now javascript! Not surprised though ... ;-)
What do these changes do?
This PR changes:
[sidecar]
should always be present), this is proof that the connection from dask-worker --> dask-scheduler --> director-v2 --> rabbitmq --> webserver --> webclient is up and running (even if some messages are missing), this makes the test more resilientRelated issue/s
How to test
DevOps Checklist