Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ do not allow start service when credits bellow zero #4905

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 23, 2023

What do these changes do?

  • ✨ do not allow start service when credits bellow zero
    image

NOTE: As discussed @bisgaard-itis we need to introduce this check also to the API-server (or start to use the same web server api to start a job)

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Microhistory milestone Oct 23, 2023
@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4905 (5faf2c9) into master (2e5d96c) will increase coverage by 11.6%.
The diff coverage is 67.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4905      +/-   ##
=========================================
+ Coverage    73.8%   85.4%   +11.6%     
=========================================
  Files         997    1004       +7     
  Lines       43600   44862    +1262     
  Branches      586     532      -54     
=========================================
+ Hits        32203   38341    +6138     
+ Misses      11266    6402    -4864     
+ Partials      131     119      -12     
Flag Coverage Δ
integrationtests 65.1% <62.5%> (+4.1%) ⬆️
unittests 84.9% <67.2%> (+10.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kages/models-library/src/models_library/wallets.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/wallets/api.py 100.0% <ø> (ø)
...er/src/simcore_service_webserver/wallets/errors.py 100.0% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py 91.7% <66.6%> (-0.4%) ⬇️
...ore_service_webserver/projects/_states_handlers.py 92.1% <80.0%> (-0.8%) ⬇️
...simcore_service_webserver/projects/projects_api.py 86.6% <40.0%> (+1.3%) ⬆️
...simcore_service_webserver/director_v2/_handlers.py 85.2% <65.8%> (+7.1%) ⬆️

... and 296 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 23, 2023 12:30
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my thought and let me know if this makes sense to you . thx!

matusdrobuliak66 and others added 3 commits October 23, 2023 14:53
…o' of github.com:matusdrobuliak66/osparc-simcore into is922/do-not-allow-to-start-job-when-credits-bellow-zero
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is only for comp service. What about dynamic ones, can we have all this fanciness for them as well?

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 23, 2023 15:53
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the imports. otherwise it's looking very good!

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2023

Code Climate has analyzed commit 5faf2c9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 85a4f94 into ITISFoundation:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants