-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ do not allow start service when credits bellow zero #4905
✨ do not allow start service when credits bellow zero #4905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4905 +/- ##
=========================================
+ Coverage 73.8% 85.4% +11.6%
=========================================
Files 997 1004 +7
Lines 43600 44862 +1262
Branches 586 532 -54
=========================================
+ Hits 32203 38341 +6138
+ Misses 11266 6402 -4864
+ Partials 131 119 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider my thought and let me know if this makes sense to you . thx!
services/web/server/src/simcore_service_webserver/director_v2/_handlers.py
Outdated
Show resolved
Hide resolved
…o' of github.com:matusdrobuliak66/osparc-simcore into is922/do-not-allow-to-start-job-when-credits-bellow-zero
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Node.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This is only for comp service. What about dynamic ones, can we have all this fanciness for them as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the imports. otherwise it's looking very good!
services/web/server/src/simcore_service_webserver/director_v2/_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/director_v2/_handlers.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_nodes_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_states_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 5faf2c9 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
NOTE: As discussed @bisgaard-itis we need to introduce this check also to the API-server (or start to use the same web server api to start a job)
Related issue/s
How to test
DevOps Checklist