-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Expose pricing plans #4828
✨ Expose pricing plans #4828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Some suggestions
- wallet credits are displayed as "XX Credits" while the pricing plan just "XX". I would add "XX Credits/hour"
- wallet credits is highlighted while princing plan is not. I would stress more the pricing plan than the wallet remaining credits (or at least give them the same importance).
In order to save some space, the short version doesn't show the unit while the
👍 |
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit 40c9683 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Sorry, what is the difference between advanced and not advanced besides the buttons having different size? Something that will come in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As IP said, I don't understand for the moment the "Advanced" view vs. the normal one.
If the normal one is don't stress the user about the "price", then I'd just show "SMALL", "MEDIUM", "LARGE"
@ignapas @elisabettai |
What do these changes do?
This PR implements the frontend part for #4812
The frontend elements stay more or the same (some extra information about the plan itself is required), but the names and the costs per unit are provided by the backend.
Related issue/s
related to ITISFoundation/osparc-issues#922
How to test
DevOps Checklist