Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🗃️ Is922/resource usage publish updated wallet credits #4762

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 15, 2023

What do these changes do?

GOAL: be able to run the whole flow and compute credits for the specified wallet

  • RUT - publish to RabbitMQ updates on wallet credits
  • RUT - 🗃️ allow multiple pricing plans for the same service
  • Director-v2 - add wallet_info & pricing plans to the Dynamic & Computational services
    • for now we pick just some default
  • Webserver - Add RUT client
  • Webserver - Prepare infrastructure for sending wallet credit updates via websocket to frontend
  • Webserver - Add real consumed credits to the wallet endpoint

NEXT connecting PR

  • connect to websocket when we have product_name available with authentification
  • extend/modify the computational part in director-v2 so we can store for each node the pricing plan and EC2 instance needed for running the service

Related issue/s

How to test

DevOps Checklist

matusdrobuliak66 and others added 30 commits August 10, 2023 17:00
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/resource usage publish updated wallet credits ✨🗃️ Is922/resource usage publish updated wallet credits Sep 19, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 19, 2023 14:20
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Please check the comments before merging!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! there are some things I would like to double check with you

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2023

Code Climate has analyzed commit 0e1b28e and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 20, 2023 08:48
@matusdrobuliak66 matusdrobuliak66 merged commit 2c48d13 into ITISFoundation:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants