-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Comp backend: Clusters-keeper can create a cluster with no wallet ID defined #4746
✨Comp backend: Clusters-keeper can create a cluster with no wallet ID defined #4746
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4746 +/- ##
========================================
+ Coverage 87.0% 87.5% +0.4%
========================================
Files 1127 945 -182
Lines 46937 42161 -4776
Branches 1013 488 -525
========================================
- Hits 40865 36912 -3953
+ Misses 5845 5138 -707
+ Partials 227 111 -116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
50924a8
to
65f7cdc
Compare
services/director-v2/src/simcore_service_director_v2/modules/clusters_keeper.py
Show resolved
Hide resolved
65f7cdc
to
cabba4e
Compare
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit cabba4e and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
allows an EC2 instance created by clusters-keeper to have a walletID set to None
Related issue/s
How to test
DevOps Checklist