Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Comp backend: Clusters-keeper can create a cluster with no wallet ID defined #4746

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 13, 2023

What do these changes do?

allows an EC2 instance created by clusters-keeper to have a walletID set to None

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:director-v2 issue related with the director-v2 service a:clusters-keeper labels Sep 13, 2023
@sanderegg sanderegg added this to the the nameless milestone Sep 13, 2023
@sanderegg sanderegg self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4746 (cabba4e) into master (8a99304) will increase coverage by 0.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4746     +/-   ##
========================================
+ Coverage    87.0%   87.5%   +0.4%     
========================================
  Files        1127     945    -182     
  Lines       46937   42161   -4776     
  Branches     1013     488    -525     
========================================
- Hits        40865   36912   -3953     
+ Misses       5845    5138    -707     
+ Partials      227     111    -116     
Flag Coverage Δ
integrationtests 65.2% <ø> (-0.1%) ⬇️
unittests 84.9% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...imcore_service_clusters_keeper/modules/clusters.py 100.0% <ø> (ø)
...rc/simcore_service_clusters_keeper/rpc/clusters.py 55.5% <ø> (ø)
.../simcore_service_clusters_keeper/utils/clusters.py 58.0% <ø> (ø)
...r/src/simcore_service_clusters_keeper/utils/ec2.py 100.0% <ø> (ø)
...ore_service_director_v2/modules/clusters_keeper.py 50.0% <ø> (-6.0%) ⬇️
...ls_library/rpc_schemas_clusters_keeper/clusters.py 100.0% <100.0%> (ø)

... and 185 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/allow_walletid_none branch from 50924a8 to 65f7cdc Compare September 13, 2023 10:16
@sanderegg sanderegg marked this pull request as ready for review September 13, 2023 10:16
@sanderegg sanderegg force-pushed the comp-backend/allow_walletid_none branch from 65f7cdc to cabba4e Compare September 13, 2023 19:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2023

Code Climate has analyzed commit cabba4e and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg merged commit 300dae0 into ITISFoundation:master Sep 13, 2023
@sanderegg sanderegg deleted the comp-backend/allow_walletid_none branch September 13, 2023 20:31
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:clusters-keeper a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants