Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Comp backend: allow to change to s3 links on on demand clusters (⚠️ devops) #4740

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 12, 2023

What do these changes do?

This PR brings some new ENVs so that on-demand clusters which are fully controlled by us may use S3 links for computations, thus allowing more than 5Gb uploads.

Related issue/s

How to test

DevOps Checklist

Ensure the following ENV are now exposed (and need to be added to the deploys):

COMPUTATIONAL_BACKEND_DEFAULT_CLUSTER_FILE_LINK_TYPE=S3
COMPUTATIONAL_BACKEND_DEFAULT_FILE_LINK_TYPE=PRESIGNED

Introduces a new ENV
COMPUTATIONAL_BACKEND_ON_DEMAND_CLUSTERS_FILE_LINK_TYPE=S3
which can be set with either S3 or PRESIGNED
this will allow to upload more than 5GB when a computational service runs in on-demand clusters

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Sep 12, 2023
@sanderegg sanderegg added this to the the nameless milestone Sep 12, 2023
@sanderegg sanderegg self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4740 (2282708) into master (300dae0) will decrease coverage by 0.1%.
The diff coverage is 80.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4740     +/-   ##
========================================
- Coverage    87.0%   87.0%   -0.1%     
========================================
  Files        1127    1127             
  Lines       46934   46938      +4     
  Branches     1013    1013             
========================================
+ Hits        40850   40851      +1     
- Misses       5857    5860      +3     
  Partials      227     227             
Flag Coverage Δ
integrationtests 65.2% <75.0%> (+<0.1%) ⬆️
unittests 84.7% <80.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../models_library/api_schemas_directorv2/clusters.py 87.3% <ø> (ø)
...ore_service_director_v2/modules/clusters_keeper.py 50.0% <ø> (ø)
...e_service_director_v2/modules/dask_clients_pool.py 93.4% <66.6%> (-1.2%) ⬇️
...ages/models-library/src/models_library/clusters.py 100.0% <100.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py 97.5% <100.0%> (+<0.1%) ⬆️

... and 3 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/allow-s3-links-on-on-demand-clusters branch from f532e1b to dc819ce Compare September 13, 2023 20:31
@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit 2282708 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit d68a9be into ITISFoundation:master Sep 14, 2023
@sanderegg sanderegg deleted the comp-backend/allow-s3-links-on-on-demand-clusters branch September 14, 2023 07:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants