-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Comp backend: allow to change to s3 links on on demand clusters (⚠️ devops) #4740
✨Comp backend: allow to change to s3 links on on demand clusters (⚠️ devops) #4740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4740 +/- ##
========================================
- Coverage 87.0% 87.0% -0.1%
========================================
Files 1127 1127
Lines 46934 46938 +4
Branches 1013 1013
========================================
+ Hits 40850 40851 +1
- Misses 5857 5860 +3
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
|
26cec08
to
53c4084
Compare
services/director-v2/src/simcore_service_director_v2/modules/dask_clients_pool.py
Show resolved
Hide resolved
f532e1b
to
dc819ce
Compare
Code Climate has analyzed commit 2282708 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR brings some new ENVs so that on-demand clusters which are fully controlled by us may use S3 links for computations, thus allowing more than 5Gb uploads.
Related issue/s
How to test
DevOps Checklist
Ensure the following ENV are now exposed (and need to be added to the deploys):
Introduces a new ENV
COMPUTATIONAL_BACKEND_ON_DEMAND_CLUSTERS_FILE_LINK_TYPE=S3
which can be set with either
S3
orPRESIGNED
this will allow to upload more than 5GB when a computational service runs in on-demand clusters