Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Frontend: Refactoring & Cleanup #4735

Merged
merged 22 commits into from
Sep 13, 2023
Merged

♻️ Frontend: Refactoring & Cleanup #4735

merged 22 commits into from
Sep 13, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 12, 2023 •
edited by YuryHrytsuk
Loading

What do these changes do?

Getting ready for the handover, not much to show here.

  • Move files around
  • Remove deprecated files
  • A bit of refactoring

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Sep 12, 2023
@odeimaiz odeimaiz changed the title Refatoring i Refactoring & Cleanup Sep 12, 2023
@odeimaiz odeimaiz changed the title Refactoring & Cleanup WIP Refactoring & Cleanup Sep 12, 2023
@odeimaiz odeimaiz changed the title WIP Refactoring & Cleanup WIP ♻️ Refactoring & Cleanup Sep 12, 2023
@odeimaiz odeimaiz marked this pull request as ready for review September 12, 2023 09:42
@odeimaiz odeimaiz changed the title WIP ♻️ Refactoring & Cleanup ♻️ Refactoring & Cleanup Sep 12, 2023
@odeimaiz odeimaiz changed the title ♻️ Refactoring & Cleanup ♻️ Frontend: Refactoring & Cleanup Sep 12, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:♻️refactor labels Sep 12, 2023
@odeimaiz odeimaiz enabled auto-merge (squash) September 12, 2023 09:42
codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6401 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6460 lines exceeds the maximum allowed for the inline comments feature.

pcrespov
pcrespov reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a big cleanup

@odeimaiz odeimaiz added this to the the nameless milestone Sep 12, 2023
codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6460 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6460 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 13, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6460 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2023

Code Climate has analyzed commit 05b1de6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit e888d90 into ITISFoundation:master Sep 13, 2023
@odeimaiz odeimaiz deleted the refatoring-i branch September 13, 2023 07:06
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 14, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
the nameless
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @pcrespov @sanderegg @matusdrobuliak66