-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Payments service: interface with payments-gateway (part 1) (devops ⚠️) #4715
✨ Payments service: interface with payments-gateway (part 1) (devops ⚠️) #4715
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4715 +/- ##
========================================
- Coverage 86.9% 85.3% -1.7%
========================================
Files 1113 1125 +12
Lines 46615 46902 +287
Branches 1013 1013
========================================
- Hits 40555 40031 -524
- Misses 5833 6644 +811
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c1364d5
to
71f34ba
Compare
39ed7e8
to
f7cf34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Please find some remarks below.
packages/models-library/src/models_library/utils/pydantic_tools_extension.py
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_gateway.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_gateway.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments. thanks!
packages/models-library/src/models_library/utils/pydantic_tools_extension.py
Show resolved
Hide resolved
4b13845
to
31be479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just had one more question
packages/models-library/src/models_library/utils/pydantic_tools_extension.py
Show resolved
Hide resolved
5e86db3
to
1814ba7
Compare
Code Climate has analyzed commit eac5977 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
This PR creates the interfaces and starts implementing the
payments
service. This service interact with four other services, namely the webserver, the payment-gateway, the resource-usage-tracker (RUT) and the postgres database. For each it uses different interfaces:This PR introduces part of this design, specifically:
api/rest
to complete paymentservices/payments_gateway
interface to communicate with payments gatewayscripts/fake_payment_gateway.py
)services/payment_gateway.py
api/rpc
The OAS of the
![image](https://private-user-images.githubusercontent.com/32402063/267084426-858d81de-d56b-407a-b376-c9b011f3aa0f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTUyMzEsIm5iZiI6MTczODkxNDkzMSwicGF0aCI6Ii8zMjQwMjA2My8yNjcwODQ0MjYtODU4ZDgxZGUtZDU2Yi00MDdhLWIzNzYtYzliMDExZjNhYTBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA3NTUzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmZjYxNGRlY2QwYTI4NWU4YjAzMDU5MzFhYWU5MzhkNDM5MDU1OTgxNDdmNTljYjg1YzcwMjdmMDYzOWJjNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mh0bG8cwvK9u0XdIYeO2d0KJW3joUS0dw2pRVYrZcs0)
api/rest
(in detail here ):Next PR will continue with
db
repository to handle transactionsocketio
to notify payments to webserverhttpx
connection to RUTRelated issue/s
How to test
cd services/payments make install-dev make tests-dev-unit
DevOps⚠️
payments
service (seedocker-compose.yml
for more details)webserver/payments
plugin until this service is fully functional.