🐛Check permissions before modifying project nodes #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
pcrespov,
GitHK and
matusdrobuliak66
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit e59ec16 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #4582 +/- ##
=========================================
- Coverage 86.7% 81.9% -4.8%
=========================================
Files 1023 447 -576
Lines 43762 23445 -20317
Branches 1014 189 -825
=========================================
- Hits 37946 19214 -18732
+ Misses 5589 4184 -1405
+ Partials 227 47 -180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
approved these changes
Aug 6, 2023
sanderegg
deleted the
bugfix/ensure-project-nodes-changed-after-permission-is-checked
branch
matusdrobuliak66
pushed a commit
that referenced
this pull request
Aug 7, 2023
16 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
ensure permission checks are done prior to adding/removing project nodes
NOTE: @matusdrobuliak66 this should go in the hotfix to staging as well
Related issue/s
How to test
DevOps Checklist