Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ—ƒ๏ธ resource usage tracker - credit tables #4578

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 4, 2023

What do these changes do?

  • ๐Ÿ—ƒ๏ธ adding DB tables to resource usage tracker
    1. Table for tracking user services
      • service_runs
    2. Tables for credit mapping
      • pricing_plans
      • pricing_details
      • pricing_plan_to_service
    3. Table for tracking of wallet credits (Balance sheet)
      • wallets_credit_transactions

Note: If there are some concrete questions I can provide you with some examples in person

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 4, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Sundae milestone Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4578 (7be3c90) into master (d5d1d85) will decrease coverage by 18.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4578      +/-   ##
=========================================
- Coverage    85.7%   67.8%   -18.0%     
=========================================
  Files        1042     590     -452     
  Lines       44424   28237   -16187     
  Branches     1014     188     -826     
=========================================
- Hits        38095   19154   -18941     
- Misses       6101    9036    +2935     
+ Partials      228      47     -181     
Flag Coverage ฮ”
integrationtests 66.6% <รธ> (-9.4%) โฌ‡๏ธ
unittests 73.6% <รธ> (-10.8%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

see 740 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: resource usage tracker - credits ๐Ÿ—ƒ๏ธ resource usage tracker - credit tables Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:resource-usage-tracker resource usage tracker service label Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 8, 2023 16:17
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! please consider my comments/questions.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just some comments

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 9, 2023 17:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit 7be3c90 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit ed5dfcc into ITISFoundation:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants