-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐๏ธ resource usage tracker - credit tables #4578
๐๏ธ resource usage tracker - credit tables #4578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4578 +/- ##
=========================================
- Coverage 85.7% 67.8% -18.0%
=========================================
Files 1042 590 -452
Lines 44424 28237 -16187
Branches 1014 188 -826
=========================================
- Hits 38095 19154 -18941
- Misses 6101 9036 +2935
+ Partials 228 47 -181
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! please consider my comments/questions.
...ages/postgres-database/src/simcore_postgres_database/models/resource_tracker_service_runs.py
Show resolved
Hide resolved
...ages/postgres-database/src/simcore_postgres_database/models/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
...ages/postgres-database/src/simcore_postgres_database/models/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
...ges/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_plans.py
Outdated
Show resolved
Hide resolved
...ges/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_plans.py
Outdated
Show resolved
Hide resolved
...es-database/src/simcore_postgres_database/models/resource_tracker_pricing_plan_to_service.py
Show resolved
Hide resolved
...s/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_details.py
Outdated
Show resolved
Hide resolved
...s/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_details.py
Outdated
Show resolved
Hide resolved
...s/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_details.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, just some comments
...es-database/src/simcore_postgres_database/models/resource_tracker_pricing_plan_to_service.py
Show resolved
Hide resolved
...atabase/src/simcore_postgres_database/models/resource_tracker_wallets_credit_transactions.py
Outdated
Show resolved
Hide resolved
...atabase/src/simcore_postgres_database/models/resource_tracker_wallets_credit_transactions.py
Show resolved
Hide resolved
...atabase/src/simcore_postgres_database/models/resource_tracker_wallets_credit_transactions.py
Outdated
Show resolved
Hide resolved
...atabase/src/simcore_postgres_database/models/resource_tracker_wallets_credit_transactions.py
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!ย ย 0 Bugs No Coverage information |
Code Climate has analyzed commit 7be3c90 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
Note: If there are some concrete questions I can provide you with some examples in person
Related issue/s
How to test
DevOps Checklist