-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Link assets folder from service to front-end #4572
✨ Link assets folder from service to front-end #4572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4572 +/- ##
=========================================
- Coverage 86.6% 85.0% -1.6%
=========================================
Files 1042 449 -593
Lines 44369 23592 -20777
Branches 1014 188 -826
=========================================
- Hits 38449 20076 -18373
+ Misses 5692 3469 -2223
+ Partials 228 47 -181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! please consider my comments
services/dynamic-sidecar/tests/unit/test_modules_outputs_event_handler.py
Show resolved
Hide resolved
services/dynamic-sidecar/tests/unit/test_modules_outputs_watchdog_extensions.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_nodes_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_nodes_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_nodes_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_nodes_api.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/02/test_projects_nodes_handler.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! please consider my comments
…-simcore-forked into pr-osparc-link-assets-to-fe
Code Climate has analyzed commit 36037fd and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
The
assets
folder is a new convension. If a service defines it in one of the states if will be used by the fronted to search for items that it can preview.Supported file types to be previewed:
".gltf", ".png", ".jpeg", ".jpg"
All files can also have a thumbnail image associated with them. Supported file types for the thumbnail:
".png", ".jpeg", ".jpg"
Important note for service maintainers
Both of the
assets
folders below will be saved asproject_id/node_id/assets
inside S3. You can freely chose where to mount the assents folder in the service.Bonus
Related issue/s
How to test
DevOps Checklist