Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Link assets folder from service to front-end #4572

Merged
merged 25 commits into from
Aug 10, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 4, 2023

What do these changes do?

The assets folder is a new convension. If a service defines it in one of the states if will be used by the fronted to search for items that it can preview.

Supported file types to be previewed: ".gltf", ".png", ".jpeg", ".jpg"
All files can also have a thumbnail image associated with them. Supported file types for the thumbnail: ".png", ".jpeg", ".jpg"


Important note for service maintainers

Both of the assets folders below will be saved as project_id/node_id/assets inside S3. You can freely chose where to mount the assents folder in the service.

paths-mapping:
  ...
  state_paths:
   ...
    - /home/jovyan/work/assets
paths-mapping:
  ...
  state_paths:
   ...
    - /some/other/random/path/assets

Bonus

  • removed some warnings from tests

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Aug 4, 2023
@GitHK GitHK added the a:webserver issue related to the webserver service label Aug 4, 2023
@GitHK GitHK added this to the Sundae milestone Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4572 (36037fd) into master (59767b4) will decrease coverage by 1.6%.
The diff coverage is 96.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4572      +/-   ##
=========================================
- Coverage    86.6%   85.0%    -1.6%     
=========================================
  Files        1042     449     -593     
  Lines       44369   23592   -20777     
  Branches     1014     188     -826     
=========================================
- Hits        38449   20076   -18373     
+ Misses       5692    3469    -2223     
+ Partials      228      47     -181     
Flag Coverage Δ
integrationtests 66.7% <34.8%> (+1.2%) ⬆️
unittests 87.1% <96.9%> (+2.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/simcore_service_webserver/projects/_nodes_api.py 88.5% <96.0%> (+10.5%) ⬆️
...core_service_webserver/projects/_nodes_handlers.py 90.9% <100.0%> (+0.6%) ⬆️
...erver/src/simcore_service_webserver/storage/api.py 59.0% <100.0%> (+12.9%) ⬆️

... and 674 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review August 9, 2023 11:47
@GitHK GitHK requested review from elisabettai and odeimaiz August 9, 2023 11:47
@GitHK GitHK requested a review from mguidon August 9, 2023 11:47
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! please consider my comments

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! please consider my comments

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit 36037fd and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@GitHK GitHK merged commit 2d66389 into ITISFoundation:master Aug 10, 2023
@GitHK GitHK deleted the pr-osparc-link-assets-to-fe branch August 10, 2023 09:08
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidecar: mount new screenshot folder @GitHK
3 participants