♻️ Remove docker node constraints from simcore repo (⚠️ DEVOPS)

[YuryHrytsuk]

What do these changes do?

It removes deprecated docker deploy placement constraints (node.platform.os == linux) since we run everything in containers and it doesn't make sense at the moment.

Related issue/s

ITISFoundation/osparc-ops-environments#278

Related PRs

• Update docker swarm placement constraints for Simcore services (:warning: DevOps) osparc-ops-environments#300
• https://git.speag.com/oSparc/osparc-infra/-/merge_requests/144

How to test

Run deployment locally and check that everything is up and running

DevOps Checklist

Nothing to do

[codecov]

Codecov Report

Merging #4571 (855ba44) into master (f8aa15d) will decrease coverage by 0.2%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4571     +/-   ##
========================================
- Coverage    86.7%   86.5%   -0.2%     
========================================
  Files        1023    1023             
  Lines       43772   43772             
  Branches     1013    1013             
========================================
- Hits        37953   37898     -55     
- Misses       5592    5647     +55     
  Partials      227     227             

Flag	Coverage Δ
integrationtests	65.3% <ø> (-1.4%)	⬇️
unittests	84.2% <ø> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

[sanderegg]

I am not sure I understand this change.
the node.platform.os == linux I agree is useless and can be removed without any issue.
But, the node.role == manager is fully justified and defines the requirements of the services.
For instance the director(s) must be on a manager node as well as the autoscaling and that is explicitely defined in the docker-compose. Additionally if I deploy that stack on multiple machines this will now fail because of that.
I do not see/understand why this is now removed.

I'm happy to discuss that.

[YuryHrytsuk]

I am not sure I understand this change. the node.platform.os == linux I agree is useless and can be removed without any issue. But, the node.role == manager is fully justified and defines the requirements of the services. For instance the director(s) must be on a manager node as well as the autoscaling and that is explicitely defined in the docker-compose. Additionally if I deploy that stack on multiple machines this will now fail because of that. I do not see/understand why this is now removed.

I'm happy to discuss that.

All the placement constraints have been moved to osparc-ops-environments. The idea is to keep all the constraints in one place to avoid duplication and to make it more transparent/clear. You can find the relevant changes in this PR. All the placement constraints in osparc-simcore have been moved to osparc-ops-environments.

[sanderegg]

as discussed I wait for the next change. Thanks a lot!

[sanderegg]

As discussed. thanks a lot for this.

[mrnicegyu11]

looks good to me, thanks a lot!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit 855ba44 and detected 0 issues on this pull request.

View more on Code Climate.