Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Feature: Connect Wallets to backend #4568

Merged
merged 39 commits into from
Aug 8, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 2, 2023

What do these changes do?

This PR adapts the frontend to the current backend models and connects to the backend.

Wallets

Related issue/s

related to ITISFoundation/osparc-issues#922
fixes ITISFoundation/osparc-issues#1050

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Aug 2, 2023
@odeimaiz odeimaiz added this to the Sundae milestone Aug 7, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Aug 7, 2023
@odeimaiz odeimaiz changed the title Feature/wallet fe ii 🎨 Feature: Connect wallets logic to backend Aug 8, 2023
@odeimaiz odeimaiz changed the title 🎨 Feature: Connect wallets logic to backend 🎨 Feature: Connect Wallets to backend Aug 8, 2023
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice 🎉

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about how the balance of each wallet works. Who keeps track of the totals?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 1d31087 and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz enabled auto-merge (squash) August 8, 2023 12:54
@odeimaiz odeimaiz merged commit 82edbc1 into ITISFoundation:master Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I am a member of an Org, but I can't see other members
4 participants