Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix e2e: openWithResources #4537

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 24, 2023

What do these changes do?

Under some circumstances, puppeteer might need to also go through the resource selection window. This PR fixes the test failing in that situation.

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz added e2e Bugs found by or related to the end-2-end testing changelog:🐛bugfix labels Jul 24, 2023
@odeimaiz odeimaiz added this to the Sundae milestone Jul 24, 2023
@odeimaiz odeimaiz self-assigned this Jul 24, 2023
@odeimaiz odeimaiz marked this pull request as ready for review July 24, 2023 12:39
@odeimaiz odeimaiz changed the title 🐛 fix e2e: openWithResources 🐛 Fix e2e: openWithResources Jul 24, 2023
@odeimaiz odeimaiz enabled auto-merge (squash) July 24, 2023 12:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 24, 2023

Code Climate has analyzed commit 3e9322f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 26d2792 into ITISFoundation:master Jul 24, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
@odeimaiz odeimaiz deleted the fix/e2e-open-with-resources branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants