-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implements study
read operations in api-server
#4511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4511 +/- ##
========================================
+ Coverage 86.4% 87.2% +0.7%
========================================
Files 1008 805 -203
Lines 43128 36448 -6680
Branches 998 483 -515
========================================
- Hits 37283 31794 -5489
+ Misses 5615 4539 -1076
+ Partials 230 115 -115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8c5b21e
to
3e0f76b
Compare
study
read operations in api-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes related to OPS. Correct me if I am wrong
@YuryHrytsuk Thx. Yes, you are right. You were added because of the (trivial) changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out my suggestion especially regarding the one regarding the pagination params. That would be the important one.
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/_utils_pydantic.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/pagination.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/errors.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/webserver.py
Show resolved
Hide resolved
2d6a7f3
to
75532e6
Compare
f1d7e6a
to
7b8dea6
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit d78b1fd and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
In the
api-server
API it implements the following operations thestudies
collectionGET
/v0/studies
GET
/v0/studies/{study_id}
GET
/v0/studies/{study_id}/ports
More details in openapi-dev.json
Extra
Page
so client producer shorter-names for the model classesRelated issue/s
How to test
DevOps
None