Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implements study read operations in api-server #4511

Merged
merged 14 commits into from
Jul 24, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 19, 2023

What do these changes do?

In the api-server API it implements the following operations the studies collection

  • GET /v0/studies
  • GET /v0/studies/{study_id}
  • GET /v0/studies/{study_id}/ports

More details in openapi-dev.json

Extra

  • renamed pagination models to Page so client producer shorter-names for the model classes

Related issue/s

How to test

  • driving test was services/api-server/tests/unit/api_studies/test_api_routes_studies.py

DevOps

None

@pcrespov pcrespov added this to the Sundae milestone Jul 19, 2023
@pcrespov pcrespov self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4511 (d78b1fd) into master (9988654) will increase coverage by 0.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4511     +/-   ##
========================================
+ Coverage    86.4%   87.2%   +0.7%     
========================================
  Files        1008     805    -203     
  Lines       43128   36448   -6680     
  Branches      998     483    -515     
========================================
- Hits        37283   31794   -5489     
+ Misses       5615    4539   -1076     
+ Partials      230     115    -115     
Flag Coverage Δ
integrationtests 68.3% <ø> (+1.5%) ⬆️
unittests 84.3% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_api_server/models/_utils_pydantic.py 100.0% <ø> (ø)
.../src/models_library/api_schemas_webserver/_base.py 90.9% <100.0%> (-0.4%) ⬇️
...c/models_library/api_schemas_webserver/projects.py 100.0% <100.0%> (ø)
...c/models_library/utils/pydantic_tools_extension.py 100.0% <100.0%> (+100.0%) ⬆️
...imcore_service_api_server/api/errors/http_error.py 100.0% <100.0%> (ø)
...src/simcore_service_api_server/api/routes/files.py 50.0% <100.0%> (ø)
...c/simcore_service_api_server/api/routes/solvers.py 51.2% <100.0%> (ø)
...core_service_api_server/api/routes/solvers_jobs.py 76.1% <100.0%> (+0.1%) ⬆️
...c/simcore_service_api_server/api/routes/studies.py 100.0% <100.0%> (+18.1%) ⬆️
...core_service_api_server/api/routes/studies_jobs.py 59.2% <100.0%> (ø)
... and 5 more

... and 212 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4177/studies-api branch from 8c5b21e to 3e0f76b Compare July 20, 2023 20:56
@pcrespov pcrespov added a:api framework api, data schemas, a:apiserver api-server service labels Jul 20, 2023
@pcrespov pcrespov changed the title WIP: Is4177/studies api ✨ Implements study read operations in api-server Jul 20, 2023
pcrespov added a commit to pcrespov/sandbox-python that referenced this pull request Jul 20, 2023
@pcrespov pcrespov marked this pull request as ready for review July 20, 2023 21:25
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov enabled auto-merge (squash) July 21, 2023 14:58
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes related to OPS. Correct me if I am wrong

@pcrespov
Copy link
Member Author

I don't see any changes related to OPS. Correct me if I am wrong

@YuryHrytsuk Thx. Yes, you are right. You were added because of the (trivial) changes in .env-devel (and you are this file's owner according to https://github.com/ITISFoundation/osparc-simcore/blob/master/.github/CODEOWNERS#L8 )

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out my suggestion especially regarding the one regarding the pagination params. That would be the important one.

@pcrespov pcrespov force-pushed the is4177/studies-api branch from 2d6a7f3 to 75532e6 Compare July 21, 2023 20:06
@pcrespov pcrespov requested a review from GitHK July 21, 2023 20:11
@pcrespov pcrespov force-pushed the is4177/studies-api branch from f1d7e6a to 7b8dea6 Compare July 21, 2023 20:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit d78b1fd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit 7389b71 into ITISFoundation:master Jul 24, 2023
@pcrespov pcrespov deleted the is4177/studies-api branch July 24, 2023 08:42
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants