Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes replace operation in projects and uninitialized variable in health-check #4469

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 6, 2023

What do these changes do?

Various errors detected in master

  • Temporary fix of PUT projects error (until proper validation of body is in place)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/projects/_handlers_crud.py", line 463, in replace_project
    Project.parse_obj(new_project)  # validate
  File "pydantic/main.py", line 511, in pydantic.main.BaseModel.parse_obj
  File "pydantic/main.py", line 331, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for Project
permalink
  extra fields not permitted (type=value_error.extra)
  • Fixes healthcheck
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/diagnostics/plugin.py", line 51, in _on_healthcheck_async_adapter
    assert_healthy_app(app)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/diagnostics/_healthcheck.py", line 98, in assert_healthy_app
    max_delay: float = incidents.max_delay()
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/diagnostics/_healthcheck.py", line 28, in max_delay
    delay: float = self.max_item.delay_secs or 0.0
AttributeError: 'NoneType' object has no attribute 'delay_secs'

Related issue/s

How to test

DevOps

None

@pcrespov pcrespov requested a review from odeimaiz July 6, 2023 15:13
@pcrespov pcrespov self-assigned this Jul 6, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jul 6, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jul 6, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit 53353cb and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov requested a review from mguidon July 6, 2023 15:14
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

@pcrespov pcrespov changed the title 🐛 Fixes errors detected in webserver 🐛 Fixes replace operation in projects and uninitialized variable in health-check Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4469 (53353cb) into master (e3b40b4) will decrease coverage by 10.2%.
The diff coverage is 25.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4469      +/-   ##
=========================================
- Coverage    82.5%   72.4%   -10.2%     
=========================================
  Files         952     395     -557     
  Lines       41997   20791   -21206     
  Branches      904     173     -731     
=========================================
- Hits        34679   15059   -19620     
+ Misses       7123    5683    -1440     
+ Partials      195      49     -146     
Flag Coverage Δ
integrationtests 68.1% <25.0%> (?)
unittests 64.1% <25.0%> (-18.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core_service_webserver/diagnostics/_healthcheck.py 50.0% <0.0%> (-46.9%) ⬇️
...mcore_service_webserver/projects/_handlers_crud.py 82.1% <100.0%> (+14.1%) ⬆️

... and 799 files with indirect coverage changes

@pcrespov pcrespov merged commit afc1eb0 into ITISFoundation:master Jul 6, 2023
@pcrespov pcrespov deleted the maintenance/errors-master branch July 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants